Support environment: from an interactive session.
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path for interactive sessions, through orderly_copy_files, was not propagating the environment from the caller to `orderly_search`. The broke support for `environment:`-style queries, but only when running interactively. In orderly_copy_files (and orderly_dependency), the `envir` parameter actually has two purposes: it provides values for `environment:` and it provides values that are substituted in the file paths to be copied. This dual usage causes a bit of confusion and may be what led to this issue. We may want to tidy up some of this in the future, possibly with the help of rlang's quosures and quasiquotation support.
richfitz
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code path for interactive sessions, through orderly_copy_files, was not propagating the environment from the caller to
orderly_search. The broke support forenvironment:-style queries, but only when running interactively.In orderly_copy_files (and orderly_dependency), the
envirparameter actually has two purposes: it provides values forenvironment:and it provides values that are substituted in the file paths to be copied. This dual usage causes a bit of confusion and may be what led to this issue. We may want to tidy up some of this in the future, possibly with the help of rlang's quosures and quasiquotation support.