Fix CI issue caused by new cli and outpack versions. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of the cli package have added a new `vec-sep2` style option for `cli_vec`, in an effort to improve their handling of Oxford commas. This means `vec-last` is now ignored for any list of length two, and the value of `vec-sep2` is used instead. We only used that feature in one place, with "or" as the value for `vec-last`. The new cli package broke a test by making that code print the default `vec-sep2` value, i.e. "and", when there are only two elements. After looking at the context of that message however, I think "and" actually makes more sense than "or". It is printing a list of paths that haven't been found. We would want all of the paths in the list to be present, not just one of them. The simplest fix is therefore to remove the call to `cli_vec` and let cli use the default settings. Finally, remove a call to `squote` on the missing paths and use a `.path` tag in the message. The end result is the same.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 3565 3564 -1
=========================================
- Hits 3565 3564 -1 ☔ View full report in Codecov by Sentry. |
|
Ah so now the coverage has changed and fails my CI because |
plietar
changed the title
richfitz
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of the cli package have added a new
vec-sep2style option forcli_vec, in an effort to improve their handling of Oxford commas. This meansvec-lastis now ignored for any list of length two, and the value ofvec-sep2is used instead.We only used that feature in one place, with "or" as the value for
vec-last. The new cli package broke a test by making that code print the defaultvec-sep2value, i.e. "and", when there are only two elements.After looking at the context of that message however, I think "and" actually makes more sense than "or". It is printing a list of paths that haven't been found. We would want all of the paths in the list to be present, not just one of them. The simplest fix is therefore to remove the call to
cli_vecand let cli use the default settings.Finally, remove a call to
squoteon the missing paths and use a.pathtag in the message. The end result is the same.