Allow use of NULL for name in dependency #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
richfitz
requested review from
r-ash and
weshinsley
and removed request for
r-ash
weshinsley
requested changes
Oct 16, 2023
| @@ -276,6 +278,9 @@ static_orderly_dependency <- function(args) { | |||
| query <- args$query | |||
| files <- args$files | |||
|
|
|||
| static_name <- static_string(name) | |||
| has_name <- !is.null(static_name) || is.null(name) | |||
There was a problem hiding this comment.
Should there be ! before is.null(name) ?
There was a problem hiding this comment.
no, here it means that "the name we have is final"
weshinsley
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of an id as a query without a name, it would also allows for queries that might compute a name, I guess. Mostly for completeness, but I made the ticket so must have run into a situation where this might have been preferable?