Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guards instead of pragma once #443

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Conversation

weshinsley
Copy link
Collaborator

With apologies to those who really prefer #pragma once, for consistency and to resolve a fairly uninteresting discussion, we're employing "code-owner's perogative" and saying we'll stay with header guards rather than #pragma once. While the "risks" of #pragma once are miniscule, there are no risks at all with the guards, other than preference, so for the sake of consistency, that's the way we'll go.

I appreciate that's not everyone's favourite thing, but it's a couple of lines per header - not important or prominent things, and there are many other more worthy things to focus in...

@matt-gretton-dann matt-gretton-dann merged commit 87127e7 into master Aug 3, 2020
@zebmason zebmason mentioned this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants