Skip to content

Commit

Permalink
Rename PathManipulationTests to PathManipulationTestBase for consistency
Browse files Browse the repository at this point in the history
This base class has no tests, and all other non-concrete test case base classes
in this file use a *TestBase convention.
  • Loading branch information
jleverenz committed Mar 17, 2017
1 parent c28a85c commit 1bde6d4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions fake_filesystem_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3958,12 +3958,12 @@ def testThatUncPathsArePreserved(self):
self.assertEqual('!!foo!bar!baz', self.filesystem.ResolvePath('!!foo!bar!baz!!'))


class PathManipulationTests(TestCase):
class PathManipulationTestBase(TestCase):
def setUp(self):
self.filesystem = fake_filesystem.FakeFilesystem(path_separator='|')


class CollapsePathPipeSeparatorTest(PathManipulationTests):
class CollapsePathPipeSeparatorTest(PathManipulationTestBase):
"""Tests CollapsePath (mimics os.path.normpath) using | as path separator."""

def testEmptyPathBecomesDotPath(self):
Expand Down Expand Up @@ -4015,7 +4015,7 @@ def testDotsInPathCollapsesToLastPath(self):
'bar', self.filesystem.CollapsePath('foo|..|yes|..|no|..|bar'))


class SplitPathTest(PathManipulationTests):
class SplitPathTest(PathManipulationTestBase):
"""Tests SplitPath (which mimics os.path.split) using | as path separator."""

def testEmptyPath(self):
Expand Down Expand Up @@ -4047,7 +4047,7 @@ def testEmptyPathComponentsArePreservedInHead(self):
self.assertEqual(('|a||b', 'c'), self.filesystem.SplitPath('|a||b||c'))


class JoinPathTest(PathManipulationTests):
class JoinPathTest(PathManipulationTestBase):
"""Tests JoinPath (which mimics os.path.join) using | as path separator."""

def testOneEmptyComponent(self):
Expand Down

0 comments on commit 1bde6d4

Please sign in to comment.