add: endianness option to scalar serde for Banderwagon (#342)

* add: endianness option to scalar serde * comment * doc and fixes * fix comment * bin file rm
mratsim · Jan 16, 2024 · c4be82d · c4be82d
1 parent 1edbc23
commit c4be82d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/constantine/serialization/codecs_banderwagon.nim b/constantine/serialization/codecs_banderwagon.nim
@@ -131,18 +131,21 @@ func deserialize*(dst: var EC_Prj, src: array[32, byte]): CttCodecEccStatus =
 ##
 ## ############################################################
 ## 
-func serialize_scalar*(dst: var array[32, byte], scalar: matchingOrderBigInt(Banderwagon)): CttCodecScalarStatus =
+func serialize_scalar*(dst: var array[32, byte], scalar: matchingOrderBigInt(Banderwagon), order: static Endianness = bigEndian): CttCodecScalarStatus =
+  ## Adding an optional Endianness param default at BigEndian
   ## Serialize a scalar
   ## Returns cttCodecScalar_Success if successful
-  dst.marshal(scalar, bigEndian)
+  dst.marshal(scalar, order)
   return cttCodecScalar_Success
+
 ## ############################################################
 ##
 ##              Banderwagon Scalar Deserialization
 ##
 ## ############################################################
 ## 
-func deserialize_scalar*(dst: var matchingOrderBigInt(Banderwagon), src: array[32, byte]): CttCodecScalarStatus =
+func deserialize_scalar*(dst: var matchingOrderBigInt(Banderwagon), src: array[32, byte], order: static Endianness = bigEndian): CttCodecScalarStatus =
+  ## Adding an optional Endianness param default at BigEndian
   ## Deserialize a scalar
   ## Also validates the scalar range
   ##
@@ -151,7 +154,7 @@ func deserialize_scalar*(dst: var matchingOrderBigInt(Banderwagon), src: array[3
   ##
   ## This special-cases (and leaks) 0 scalar as this is a special-case in most protocols
   ## or completely invalid (for secret keys).
-  dst.unmarshal(src, bigEndian)
+  dst.unmarshal(src, order)
   let status = validate_scalar(dst)
   if status != cttCodecScalar_Success:
     dst.setZero()