Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pb_parsing_util
was adding "packed" option for float repeated fields in proto3 syntax unconditionally. In previous implementation there was a singlePb_option
module with last-write-wins semantics, after refactoring of options there wasPb_raw_option
with compilation phase toPb_option
and different semantics: adding more "packed" field resulted in it being compiled to"packed": [true,true]
, as repetion of options in Protobuf means it's a destructured list. That unconditional overriding of option stopped working as expected, and as integration tests were not run duringdune runtest
, this went under the radars unfortunately when I was introducing options refactoring. I've added an explicit test which catches this problem, and separate commit which fixes this behavior (via newPb_raw_option.add_or_replace
which removes previous values if any).@c-cube please take a look. I've verified that this fixes the test run and build on your branch with resurrection of integration tests.