Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More compliant options parsing #242

Merged
merged 11 commits into from
Apr 1, 2024
Merged

More compliant options parsing #242

merged 11 commits into from
Apr 1, 2024

Commits on Feb 26, 2024

  1. Stop special-casing option parsing in field_option

    @Lupus
    Lupus committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    52d9ee7 View commit details
    Browse the repository at this point in the history

  2. Use adequate types to represent option names 

    See https://protobuf.com/docs/language-spec#option-names
    @Lupus
    Lupus committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2df18e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Destructure option names to nested messages

    @Lupus
    Lupus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    efb3894 View commit details
    Browse the repository at this point in the history

  2. WIP: Introduce Pb_raw_option

    @Lupus
    Lupus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b1002fe View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Proper compilation of options

    @Lupus
    Lupus committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8c3dbd5 View commit details
    Browse the repository at this point in the history

  2. Remove merge from Pb_option 

    It's unsound to merge two sets of (compiled) Pb_options
    @Lupus
    Lupus committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ba200df View commit details
    Browse the repository at this point in the history

  3. Make Pb_raw_option.merge actually override options

    @Lupus
    Lupus committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    2e42b6a View commit details
    Browse the repository at this point in the history

  4. Add documentation

    @Lupus
    Lupus committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    f6df3fd View commit details
    Browse the repository at this point in the history

  5. Even moar documentation

    @Lupus
    Lupus committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    733f4c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Support OCaml 4.08 (missing List.equal)

    @Lupus
    Lupus committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    86dd22c View commit details
    Browse the repository at this point in the history

  2. String.starts_with...

    @Lupus
    Lupus committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5f3beb0 View commit details
    Browse the repository at this point in the history