Expose pb options to ocaml types #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
reviewed
Jan 17, 2024
|
Thank you, this is indeed going to be handy in tandem with expect tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus commit includes extracting enum value options out of the parser, they were just ignored previously 😊
A special plugin is introduced, which dumps internal representation of OCaml type tree as comments to resulting target
.mlfile. It server two purposes - (1) produces output for expect tests, as it dumps options associated with various types, and this ensures that options are parsed and transferred correctly between compilation stages; and (2) it serves as an aid for custom plugin developers, as looking at this dump is really helpful before writing any code to actually pattern match the OCaml type tree and generate something out of it.I already have implemented a prototype-level plugin that generates validation rules out of PGV annotations, having protobuf options exposed along with OCaml type tree is a hard requirement for such kinds of plugins.