Expect-style tests for parser #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
reviewed
Aug 21, 2023
c-cube
reviewed
Aug 21, 2023
|
This looks very nice, and the |
Lupus
force-pushed
the
expect-tests
branch
2 times, most recently
from
eddb516
to
aabbc0e
Compare
|
@c-cube I've improved output a bit, and fixed compilation issue on older OCaml version. Please take a look, should be ready to merge. |
|
Indeed, the `executable` stanza is passive, but `test` adds a lot of default behaviors (such as checking the output against an expected file if present).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests an expect-style framework for testing compiler library and includes some tests for demonstration of the approach.
Sorry for ugly expect output, my
Format-fu is pretty low...