Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @actions/core to 1.10.0 #113

Merged

Conversation

erzz
Copy link
Contributor

@erzz erzz commented Oct 26, 2022

according to aws-actions/configure-aws-credentials#540 it can perhaps resolve #112

@mr-smithers-excellent
Copy link
Owner

@erzz - nice! Thanks for the PR. I'm realizing I didn't leave the best (or any) contribution instructions in the README.

You'll need to run npm run build && git add dist/, which I'm realizing I have set up in a husky pre-commit hook.

@erzz erzz force-pushed the output-deprecation branch from c3e0f5e to 7abd0fb Compare October 27, 2022 08:59
@erzz
Copy link
Contributor Author

erzz commented Oct 27, 2022

@mr-smithers-excellent - done!

NP: Just figured it was worth a try and then I can test from one of my repos if the output warnings are gone. If not then consider it LCM :)

@mr-smithers-excellent
Copy link
Owner

/ok-to-test

@mr-smithers-excellent
Copy link
Owner

Looks like the warnings are still lingering, but we can get this merged anyhow and follow that open GH issue.

https://github.com/mr-smithers-excellent/docker-build-push/actions/runs/3338506646

@erzz
Copy link
Contributor Author

erzz commented Oct 28, 2022

Well we tried 🤷🏻

@mr-smithers-excellent mr-smithers-excellent merged commit ba1d787 into mr-smithers-excellent:master Oct 28, 2022
@erzz erzz deleted the output-deprecation branch November 1, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set output warning when running this action
2 participants