Adding Typescript typings. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would these be compatible with the ones in https://github.com/mqttjs/MQTT.js/blob/master/types/lib/types.d.ts? I mean, if we add these here should we change them in MQTT.js to use this instead? Can you prepare that PR as well? |
|
Yeah, that would make sense. I'll prepare the PR and let you know when it's ready. |
|
@mcollina PR mqttjs/MQTT.js#819 is ready. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packet typings were basically taken from https://github.com/mqttjs/MQTT.js/blob/master/types/lib/types.d.ts, with a minor addition: the ISubscription interface. This is due to me trying to write Aedes typescript bindings, and that additional interface would be helpful there.