Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): allow will payload to be string #147

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(types): allow will payload to be string #147

merged 1 commit into from
Mar 25, 2024

Conversation

Boudewijn26
Copy link
Contributor

No description provided.

@Boudewijn26 Boudewijn26 mentioned this pull request Nov 10, 2023
Open
@robertsLando robertsLando changed the title Allow will payload to be string fix(types): allow will payload to be string Nov 10, 2023
@Boudewijn26
Copy link
Contributor Author

@mcollina Kind reminder this has an open review request. We ran into this issue again

mcollina
mcollina approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit 1f2cf7f into mqttjs:master Mar 25, 2024
3 checks passed
@robertsLando
Copy link
Member

@mcollina Could you release a patch please?

@Boudewijn26 Boudewijn26 deleted the patch-1 branch March 25, 2024 10:41
@robertsLando
Copy link
Member

@mcollina Ping

@robertsLando
Copy link
Member

@mcollina Ping please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Boudewijn26 @robertsLando @mcollina