process.nextTick and io.js versions up to 1.7.1

[quentin-ol]

Hello everyone,

in https://github.com/mqttjs/mqtt-packet/blob/master/writeToStream.js#L10, there is a test based on the string process.version. To my understanding, this heuristic guesses if one can pass arguments to process.nextTick or if wrapping is necessary, in which case tickShim is used: https://github.com/mqttjs/mqtt-packet/blob/master/writeToStream.js#L12 .

The shim is necessary for versions of io.js up to 1.7.1 (nodejs/node#1077), versions that the heuristic do not match.

I don't know if you have any plan on supporting older versions of io.js, I'm myself stuck with this version until nwjs (https://github.com/nwjs/nw.js) releases 0.13 in the stable branch but hot-fixing this shouldn't take too much effort, though (I can initiate a PR if this helps).

Regards,

Quentin

[mcollina]

If you can send a PR, that would be awesome :). You can always use v3 in
the meantime, it does not use nextTick (but it is way slower!)
Il giorno mar 10 nov 2015 alle 16:36 Quentin Lampin <
[email protected]> ha scritto:

Hello everyone,

in https://github.com/mqttjs/mqtt-packet/blob/master/writeToStream.js#L10,
there is a test based on the string process.version. To my understanding,
this heuristic guesses if one can pass arguments to process.nextTick or
if wrapping is necessary, in which case tickShim is used:
https://github.com/mqttjs/mqtt-packet/blob/master/writeToStream.js#L12 .

The shim is necessary for versions of io.js up to 1.7.1 (nodejs/node#1077
nodejs/node#1077), versions that the heuristic
do not match.

I don't know if you have any plan on supporting older versions of io.js,
I'm myself stuck with this version until nwjs (
https://github.com/nwjs/nw.js) releases 0.13 in the stable branch but
hot-fixing this shouldn't take too much effort, though (I can initiate a PR
if this helps).

Regards,

Quentin

—
Reply to this email directly or view it on GitHub
#7.