Skip to content

Commit

Permalink
options: disable --allow-delayed-peak-detect by default
Browse files Browse the repository at this point in the history 
Peak detection greatly increases HDR experience. Performance hit of
non-delayed detection is not that significant and is in line with
current default settings.
  • Loading branch information
@kasper93 @haasn
kasper93 authored and haasn committed Oct 25, 2023
1 parent 06c26e3 commit 869faad
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions DOCS/interface-changes.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ Interface changes
- add `playlist-next-playlist` and `playlist-prev-playlist` commands
- change `video-codec` to show description or name, not both
- deprecate `--cdda-toc-bias` option, offsets are always checked now
- disable `--allow-delayed-peak-detect` by default
--- mpv 0.36.0 ---
- add `--target-contrast`
- Target luminance value is now also applied when ICC profile is used.
Expand Down
2 changes: 1 addition & 1 deletion DOCS/man/options.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6698,7 +6698,7 @@ them.
frame when beneficial for performance. In particular, this is required to
avoid an unnecessary FBO indirection when no advanced rendering is required
otherwise. Has no effect if there already is an indirect pass, such as when
advanced scaling is enabled. Defaults to on. (Only affects
advanced scaling is enabled. Defaults to no. (Only affects
``--vo=gpu-next``, note that ``--vo=gpu`` always delays the peak.)

``--hdr-peak-percentile=<0.0..100.0>``
Expand Down
2 changes: 1 addition & 1 deletion etc/builtin.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ correct-downscaling=no
linear-downscaling=no
sigmoid-upscaling=no
hdr-compute-peak=no
allow-delayed-peak-detect=yes

[high-quality]
scale=ewa_lanczossharp
hdr-peak-percentile=99.995
hdr-contrast-recovery=0.30
allow-delayed-peak-detect=no
deband=yes

# Deprecated alias
Expand Down
1 change: 0 additions & 1 deletion video/out/vo_gpu_next.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2217,7 +2217,6 @@ const struct vo_driver video_out_gpu_next = {
.uninit = uninit,
.priv_size = sizeof(struct priv),
.priv_defaults = &(const struct priv) {
.delayed_peak = true,
.inter_preserve = true,
},

Expand Down

2 comments on commit 869faad

@hooke007
Copy link
Contributor

@hooke007 hooke007 commented on 869faad Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in fast profile you‘ve disabled Peak detection...

When using --hdr-compute-peak, allow delaying the detected peak by a frame when beneficial for performance.

If hdr-compute-peak was disabled. Shouldn't --allow-delayed-peak-detect did nothing here?

@kasper93
Copy link
Contributor Author

@kasper93 kasper93 commented on 869faad Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does nothing, but is a setting that can be set. And if someone enables peak-detect it would still be delayed by default.

To be honest this should be one option, --hdr-compute-peak=<no|yes|delayed>, separating delay doesn't really make sense, but it it what it is.

Please sign in to comment.