Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that we have an import_std configuration in the test-set #637

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

burnpanck
Copy link
Contributor

also, update flake8

@mpusz
Copy link
Owner

mpusz commented Nov 13, 2024

Ahh, I forgot to say that it also requires C++23+ to work 😢

Also, I do not know why a freestanding build failed.

FYI, I am providing a 3-day training from today, so I may be less responsive than usual.

@mpusz
Copy link
Owner

mpusz commented Nov 13, 2024

I've just changed the CI scripts (but not the generator) to account for C++23. They should also check for something like import_std_support when provided by the matrix.

@burnpanck
Copy link
Contributor Author

the freestanding build failed because of an issue you seemed to have previously identified: In Debug builds, the CMakeCheckCompiler test fails due to a missing _main symbol. you had an "exclude" in the matrix, but "include" comes after, so we have to account for that in the generator. I forgot about that when I added that special "cxx_modules" subsample.

@burnpanck
Copy link
Contributor Author

I might try to merge freestanding with the hosted conan, making this just another dimension of the matrix. I'll also extract the cxx_modules into its own dimension, and ensure all the unsupported combinations are skipped.

@burnpanck
Copy link
Contributor Author

finally, I'll experiment with a truly random sample of configurations, together with a GitHub Actions "manual_trigger" with a user input to choose the random seed. I belive that should be possible.

@mpusz
Copy link
Owner

mpusz commented Nov 13, 2024

WOW! You are a true GitHub Actions Wizard! 😄 I would never come up with those solutions by myself. It is great to learn those things from you. Thanks!

@mpusz
Copy link
Owner

mpusz commented Nov 13, 2024

Also, it seems that there is some issue with contracts setting as it resolves to an empty string instead of "none" here:
https://github.com/mpusz/mp-units/actions/runs/11826393072/job/32952538814#step:15:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants