Fix encoding issue #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mprimi#7 using a Blob rather than btoa (as btoa() creates a Base64-encoded ASCII string). Side modifiation, the {{VALUES}}\n substitution does not works on my environnement as the substituion is searching for a litteral \n in the template. Feel free to remove this modification if it's not relevant and I juste missed something along the way :-)
|
Thank you very much @TeddyBear06! I struggled and googled a bunch regarding b64 encoding of non-ascii, but didn't come upon this. It's maybe one of those things that is so obvious to web/JS developers that there's not a lot of Q&A online. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7 using a Blob rather than btoa (as btoa() creates a Base64-encoded ASCII string).
Side modification, the
{{VALUES}}\nsubstitution does not works on my environnement (even if I take care about Linux vs Windows line feeds...). Feel free to remove this modification if it's not relevant and I just missed up something along the way :-)