Skip to content

Commit

Permalink
Remove misleading comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jonas-schulze committed Sep 25, 2020
1 parent c77639e commit 911cdec
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 23 deletions.
4 changes: 0 additions & 4 deletions src/solve.jl
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ function solve(
# TODO: use `@spawn` instead of `@threads for` for better composability.
# For as long as tasks can't jump between threads, `@spawn` is quiet unreliable
# in populating different threads. Therefore we stick to `@threads` for now.
# Once the following PR is merged (maybe Julia v1.6), nested calls to `@threads`
# will be parallelized as well.
#
# https://github.com/JuliaLang/julia/pull/36131#pullrequestreview-425193294
tasks = asyncmap(ws, countfrom(1, nt)) do w, i
_conns = @view conns[i:i+nt]
@spawnat w begin
Expand Down
17 changes: 0 additions & 17 deletions src/types.jl
Original file line number Diff line number Diff line change
@@ -1,31 +1,14 @@
"""
doc
"""
struct ParaRealAlgorithm{CoarseAlgorithm,
FineAlgorithm,
UpdateFunction,
} <: DiffEqBase.DEAlgorithm
"""
* Will be called like `coarse(prob)`
* Must return an integrator `integrator` that allows for `reinit!(integrator, u0)` and `solve!(integrator)`
"""
coarse::CoarseAlgorithm
"same as `coarse`"
fine::FineAlgorithm
"how to merge coarse and fine solutions"
update!::UpdateFunction
end

ParaRealAlgorithm(coarse, fine) = ParaRealAlgorithm(coarse, fine, default_update!)

#=
struct ParaRealCache <: OrdinaryDiffEqMutableCache
end
struct ParaRealConstantCache <: OrdinaryDiffEqConstantCache
end
=#

function default_update!(y_new, y_coarse, y_fine, y_coarse_old)
@. y_new = y_coarse+y_fine-y_coarse_old
nothing
Expand Down
2 changes: 0 additions & 2 deletions src/worker.jl
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ function _solve(prob,

if niters > maxiters
@warn "Worker $step/$n reached maximum number of iterations: $maxiters"
#close(next)
#return maxiters == 1 ? coarse_sol : fine_sol
end

# If this worker converged, there is no need to pass on the
Expand Down

0 comments on commit 911cdec

Please sign in to comment.