implement zarr3 support for grib #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
reviewed
Nov 21, 2024
kerchunk/combine.py
Outdated
| @@ -491,9 +494,9 @@ def second_pass(self): | |||
| if f"{v}/.zgroup" in fns: | |||
| # recurse into groups - copy meta, add to dirs to process and don't look | |||
| # for references in this dir | |||
| self.out[f"{v}/.zgroup"] = m[f"{v}/.zgroup"] | |||
| self.out[f"{v}/.zgroup"] = m.fs.cat(f"{v}/.zgroup") | |||
There was a problem hiding this comment.
I dont think that this works with zarr 2
mpiannucci
reviewed
Nov 21, 2024
kerchunk/combine.py
Outdated
| @@ -443,8 +446,8 @@ def store_coords(self): | |||
| logger.debug("Written coordinates") | |||
| for fn in [".zgroup", ".zattrs"]: | |||
| # top-level group attributes from first input | |||
| if fn in m: | |||
| self.out[fn] = ujson.dumps(ujson.loads(m[fn])) | |||
| if m.fs.exists(fn): | |||
There was a problem hiding this comment.
Ask the zarr store or dict if this exists rather than hitting the fielsystem directly so it is compatible with zarr python 2
|
Im going to merge this in and then spec out what needs to be done from there back on the main v3 branch i was working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates serialization logic for zarr3 support, updates relevant API usage in grib2.py and combine.py, and updates tests accordingly.
xarray-datatreetests have been skipped for now, but a followup PR should re-implement the related behaviors around the new version of xarray which includesxarray.Datatree