fix(logging): fix so trace id is included in log #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GoogleCloudPlatform#1412) Fixes GoogleCloudPlatform#944 Conditional for Spanner is based on missing beans of type SpannerTransactionManager instead of PlatformTransactionManager, this way it always gets created if Spanner libs are pulled in Conditional for Datastore is based on missing beans of type DatastoreTransactionManager instead of PlatformTransactionManager, this way it gets created if Datastore libs are pulled in. It is the user's responsibility to designate the transaction's right transaction manager: ``` @transactional(transactionManager = "spannerTransactionManager") ``` ``` @transactional(transactionManager = "datastoreTransactionManager") ```
GoogleCloudPlatform#1848) This pr adds an integration test to `spring-cloud-gcp-data-multi-sample` for the scenario of both Datastore and Spanner Transaction manager working in the same app. It is a followup on GoogleCloudPlatform#1412
…#1883) * fix: pull-endpoint setting for async subscribers * add integration test and fix fqn subscription usage Fixes: GoogleCloudPlatform#1882.
…form#1896) * Removes duplicated test helper classes that were copied to the spring generator module, with gapic-generator-java 2.20.0 now providing a testlib jar
…d versions not available in maven central (GoogleCloudPlatform#1910)
…gleCloudPlatform#1900) This fixes the compile error in iap-sample and firebase-sample and should unblock Spring Boot 3.1.0 GoogleCloudPlatform#1874. However, iap sample does not run as described in [README](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/spring-cloud-gcp-samples/spring-cloud-gcp-security-iap-sample/README.adoc?plain=1#L52-L64) for me. firebase sample also not working as expected. Neither sample come with test and may have been broken before this change. Need to be further investigated. Filed GoogleCloudPlatform#1860 to track.
…ogleCloudPlatform#1905) Bumps `gapic-generator-java-bom.version` from 2.20.0 to 2.20.1. Updates `gapic-generator-java-bom` from 2.20.0 to 2.20.1 - [Release notes](https://github.com/googleapis/sdk-platform-java/releases) - [Changelog](https://github.com/googleapis/sdk-platform-java/blob/main/CHANGELOG.md) - [Commits](googleapis/sdk-platform-java@v2.20.0...v2.20.1) Updates `gapic-generator-java` from 2.20.0 to 2.20.1 - [Release notes](https://github.com/googleapis/sdk-platform-java/releases) - [Changelog](https://github.com/googleapis/sdk-platform-java/blob/main/CHANGELOG.md) - [Commits](googleapis/sdk-platform-java@v2.20.0...v2.20.1) --- updated-dependencies: - dependency-name: com.google.api:gapic-generator-java-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.api:gapic-generator-java:testlib dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eCloudPlatform#1904) Bumps [spring-cloud-dependencies](https://github.com/spring-cloud/spring-cloud-release) from 2022.0.2 to 2022.0.3. - [Commits](spring-cloud/spring-cloud-release@v2022.0.2...v2022.0.3) --- updated-dependencies: - dependency-name: org.springframework.cloud:spring-cloud-dependencies dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…loudPlatform#1891) Bumps [requests](https://github.com/psf/requests) from 2.28.2 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.28.2...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…atform#1889) Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.2 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.2...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…yle-plugin to v3.3.0 (GoogleCloudPlatform#1888)
…rm#1886) Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-source-plugin@maven-source-plugin-3.2.1...maven-source-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-source-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps commons-io from 2.11.0 to 2.12.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (main) (GoogleCloudPlatform#1918) * fix(deps): update dependency com.google.cloud:libraries-bom to v26.16.0 * chore: update starter modules in spring-cloud-previews --------- Co-authored-by: Cloud Java Bot <[email protected]>
* chore(main): release 4.4.0 * chore(main): release 4.4.0 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore(main): release 4.4.1-SNAPSHOT * chore(main): release 4.4.1-SNAPSHOT --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
zhumin8
force-pushed
the
graalvm-logging-support
branch
from
d72f78c to
be77d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly registered more than enough. Look for cleanup.
log entry written by sample:
But integration test in sample fails.