Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent logging events from always returning true #18

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

rmi22186
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

All of our logX methods would first call self.eventHandler.logX, and then return true. This results in always returning true even if the self.eventHandler.logX returns false. We should return the boolean that self.eventHandler.logX returns, which comes from a kit.

Testing Plan

  • Was this tested locally? If not, explain why.
    I imported this file locally in the GMP kit and re-built the GMP kit. Previously, the kit would return false to the wrapper, but the wrapper would still call the reportingService because it ignores the false that the kid returns. Now that we return the boolean that self.eventHandler.logX returns, this works as expected.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 merged commit 7ae86a0 into development Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants