fix: Prevent logging events from always returning true #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development
Summary
All of our
logX
methods would first callself.eventHandler.logX
, and thenreturn true
. This results in always returning true even if theself.eventHandler.logX
returnsfalse
. We should return the boolean thatself.eventHandler.logX
returns, which comes from a kit.Testing Plan
I imported this file locally in the GMP kit and re-built the GMP kit. Previously, the kit would return
false
to the wrapper, but the wrapper would still call thereportingService
because it ignores thefalse
that the kid returns. Now that we return the boolean thatself.eventHandler.logX
returns, this works as expected.Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)