New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent consent from updating if it has not changed #41

Closed

rmi22186 wants to merge 2 commits into master from fix/SQDSDKS-6232-prevent-re-setting-consent

Collaborator

rmi22186 commented Apr 2, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Upon initialization of the OneTrust kit, we added consent to the user even if consent did not change. This PR prevents that.

Testing Plan

Was this tested locally? If not, explain why. - injected code into customer sites to test if bug was resolved.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6232

rmi22186 added 2 commits

April 2, 2024 16:02


          lint oneTrustWrapper.js

11d4f0d


          fix: Prevent consent from updating if it has not changed

53fa75c

rmi22186 requested a review from alexs-mparticle

April 2, 2024 21:23

Collaborator Author

rmi22186 commented Apr 2, 2024

closed in lieue of #42

rmi22186 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet