feat: Support setting for OneTrust auto-block prevention #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [2.1.2](v2.1.1...v2.1.2) (2024-09-19) ### Bug Fixes * Always send default consent payload (if available) before updating ([4c88305](4c88305))
rmi22186
force-pushed
the
feat/SQDSDKS-6520-support-OT-auto-block
branch
from
4177a89 to
5a89bd7
Compare
alexs-mparticle
requested changes
Sep 24, 2024
src/initialization.js
Outdated
|
|
||
| return true; | ||
| } | ||
|
|
||
| function loadSnippet(url, dataLayerName) { | ||
| function loadSnippet(url, dataLayerName, settings) { |
There was a problem hiding this comment.
This might come across as a nitpick, but I don't see any benefit passing in the entire settings object just for a single setting. Unless we start needing several settings in the function, I would just add preventAutoBlock in as an argument.
alexs-mparticle
approved these changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
# [2.2.0](v2.1.2...v2.2.0) (2024-09-30) ### Features * Support setting for OneTrust auto-block prevention ([#52](#52)) ([687fcd2](687fcd2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Under certain circumstances, OneTrust will autoblock GTM from loading because it is a known tracker. Per OneTrust docs, this can be prevented by adding a
data-ot-ignoreattribute to the script tag.Testing Plan
data-ot-ignoreattribute, and does successfully add the attribute when viewingElementsin the inspector. See the screenshot belowReference Issue (For mParticle employees only. Ignore if you are an outside contributor)