fix: Prevent unmapped events from being forwarded #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
approved these changes
Nov 1, 2021
rmi22186
added a commit
that referenced
this pull request
Nov 11, 2021
rmi22186
added a commit
that referenced
this pull request
Nov 11, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
# [2.1.0](v2.0.1...v2.1.0) (2021-11-11) ### Bug Fixes * Correct send_to in gtag API ([#23](#23)) ([af01adc](af01adc)) * Prevent unmapped events from being forwarded ([#22](#22)) ([50e6d27](50e6d27)) ### Features * Implement option to switch between conversion_async and gtag ([#20](#20)) ([198e232](198e232))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an event with
MessageTypeofPageViewofPageEventis sent from the core SDK and is not mapped in a Google Ad words configuration, the currently logic still permits these events to be sent to Google's Adwords servers. This PR fixes this.