Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQDSDKS-5551 Changing test for sideloading kits feature #151

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

markvdouw
Copy link

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Changing test for sideloading kits feature

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markvdouw markvdouw merged commit 3d8431e into development Jul 21, 2023
@markvdouw markvdouw deleted the feat/SQDS-5551_fix_sideloaded_integration branch July 21, 2023 02:56
markvdouw pushed a commit that referenced this pull request Dec 21, 2023
* fix: Manually adding custom attributes for NON PURCHASE EVENTS (#147)

* Manually adding custom attributes for NON PURCHASE EVENTS

* Adding commented test

* fix: Forward Custom Attributes for all Commerce Events (#150)

* feat: SQDSDKS-5551 Changing test for sideloading kits feature (#151)

Fixing test to accomodate new architecture change for sideloaded kits

* chore: bump android-sdk-ui from 24.3.0 to 25.0.0 (#133)

:arrow_up: Upgrade Braze Android SDK from v24 to v25

* fix: flip supportsAttributeLists back to true (#162)

Signed-off-by: jshin-tse <[email protected]>

* Bumping min version to API 21 based on Braze documentation
Bumping to latest Braze version

---------

Signed-off-by: jshin-tse <[email protected]>
Signed-off-by: markvdouw <[email protected]>
Co-authored-by: Brandon Stalnaker <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: jshin-tse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants