Enable CORS #85
Merged
Enable CORS #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abbycabs
commented
Aug 14, 2015
abbycabs
commented
- http://enable-cors.org/server_expressjs.html
|
This will let us start working on #72 |
|
@guahanweb - could use a review here if you're familiar w/ express! |
| @@ -54,6 +54,12 @@ module.exports = function (badgerService) { | |||
| state: 'none' | |||
| }); | |||
|
|
|||
| app.use(function (req, res, next) { | |||
| res.header('Access-Control-Allow-Origin', '*'); | |||
| res.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept'); | |||
There was a problem hiding this comment.
The only thing to consider is whether there are ever going to be additional headers that may be sent from the client. Things like Cache-Control or other browser headers that may be injected?
This is a pretty generic "catch-all" that is good for general CORS. Just be sure your client isn't attaching any unexpected headers.
There was a problem hiding this comment.
This is a good point - we should def revisit when we add a CDN.
|
cr:gh - LGTM, just consider the header comment. If you're confident with those, I'd say merge it! |
|
Thanks @guahanweb :) |
guahanweb
pushed a commit
to guahanweb/PaperBadger
that referenced
this pull request
Aug 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.