Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the docker setup such that it mounts the local source directo… #179

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

jonocodes
Copy link
Contributor

…ry for development instead of building a production image.

…ry for development instead of building a production image.
@abbycabs
Copy link
Member

This looks good to me, but I'm not super familiar with Docker :)

@josmas - I'd like your thoughts here, if you get a chance!

@josmas
Copy link
Member

josmas commented Mar 30, 2016

hey all,

@jonocodes I am getting the following (which I've never seen before):

$ docker-compose build
ERROR: In file './docker-compose.yml' service 'version' doesn't have any configuration options.
All top level keys in your docker-compose.yml must map to a dictionary of configuration options.

A quick search points towards differences in versions used; these are mine (on Mac 10.11.3):

$ docker-compose -v
docker-compose version 1.5.2, build 7240ff3

$ docker -v
Docker version 1.9.1, build a34a1d5

Same error with docker-compose up. Any ideas? If the changes need a particular version to run, could that be added to the Readme?

@josmas
Copy link
Member

josmas commented Mar 30, 2016

@jonocodes as usual, just when I hit enter I realised that the docker-compose version is already specified in the Readme... DOH!
Sorry about that! I'll upgrade when I get a chance and give it another go.

@josmas
Copy link
Member

josmas commented Mar 30, 2016

@acabunoc @jonocodes works nicely after upgrading to docker-compose 1.6

R+ Thanks for the changes!

@abbycabs
Copy link
Member

Sweet! Thanks @jonocodes & @josmas

@abbycabs abbycabs merged commit 7c1e2e6 into mozillascience:master Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants