-
Notifications
You must be signed in to change notification settings - Fork 218
update to new Google search codes (fixes issue #885) #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like we got these right the first time. keyword should be client. And the ie and oe can be removed.
Can you show me where this code is used? Does Reality report anything search related to telemetry? |
We need to get this fixed ASAP if we are getting more distribution. |
+lars
- sent from my mobile
…________________________________
From: Michael Kaply <[email protected]>
Sent: Monday, January 7, 2019 2:33 PM
To: MozillaReality/FirefoxReality
Cc: Subscribed
Subject: Re: [MozillaReality/FirefoxReality] update to new Google search codes (fixes issue #885) (#916)
We need to get this fixed ASAP if we are getting more distribution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#916 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGhDBOKW-qNkh4_nCBEYQE_c7OAgyj-Vks5vA8tPgaJpZM4Zo2BR>.
|
…moved `ie` and `oe` charsets (per @mkaply)
Yes, our Telemetry pings suggest that we are using a variety of search engines. (MoCo-Private Telemetry Query Dashboard: https://sql.telemetry.mozilla.org/queries/58566#151919)
@mkaply: per your review comment #916 (review), I made those adjustments to this PR. does it look good now? P.S. I'm not familiar with our search arrangement, but I'll help make sure we ship out a new version ASAP once this is merged. also, I'm not sure of the context, but @larsbergstrom can probably coordinate the logistics to make sure the malformed search queries can still been accounted for. |
@MortimerGoro Can you please take a look at this code? It looks good to me. @cvan @mkaply Unfortunately, we don't have any insights beyond our telemetry dashboard that tracks the queries performed to be able to see on the "backend" whether our search queries are working correctly or not, since it's aggregated with all Fx products sharing those codes. |
That's actually what we need. Can we get access to your search telemetry data so we can integrate into the new dashboards once these codes are live? |
@larsbergstrom LGTM |
If you check out the link @cvan provided to the internal query, in theory our data will just show up in any dashboard you write against Firefox search telemetry, as we are using the same reporting, but with Feel free to hit us up on Slack if you have more detailed questions on that bit! |
@MozillaReality/fxr-eng @larsbergstrom @philip-lamb: now that this PR is merged to |
@cvan Yes, we'll probably want both this fix and the one for bookmarks, which was blocking an update to Firefox Reality in the HTC store (they caught it during review!). |
fixes issue #885. r? @mkaply to confirm.
context