Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Switch Google search code to new code #885

Closed
mkaply opened this issue Dec 11, 2018 · 6 comments
Closed

Switch Google search code to new code #885

mkaply opened this issue Dec 11, 2018 · 6 comments
Assignees
Milestone

Comments

@mkaply
Copy link

mkaply commented Dec 11, 2018

So we are going to make a simple switch for the search code. We'd also like to rename the engine to make it clear it's using the new code.

Change will be to add -o to the end of the codes:

firefox-b-1-o | firefox-b-o

There will no longer be a separate code (-ab) for using the address bar.

@cvan
Copy link
Contributor

cvan commented Dec 11, 2018

@mkaply thanks for filing. is there a particular date for this to be changed - or effective immediately?

@cvan cvan added this to the v1.2 milestone Dec 11, 2018
@mkaply
Copy link
Author

mkaply commented Dec 12, 2018

As soon as you can (no need for a release just for this).

@keianhzo
Copy link
Contributor

keianhzo commented Dec 13, 2018

@mkaply @cvan we are using browser-search android component for this now so this will be ready as soon as mozilla-mobile/android-components#1563 lands. We will just need to update the AC version.

@mkaply
Copy link
Author

mkaply commented Dec 13, 2018

Will we be able to use a different code for Reality?

@keianhzo
Copy link
Contributor

@mkaply Yes, we can override any search plugin assets from AC in FxR to use different codes.

@cvan cvan modified the milestones: v1.1.1, v1.2 Jan 3, 2019
@cvan cvan self-assigned this Jan 3, 2019
@cvan cvan modified the milestones: v1.2, v1.1.2 Jan 8, 2019
cvan added a commit that referenced this issue Jan 8, 2019
* update to new Google search codes (fixes issue #885)

* Google Search URL query-string fixes: fixed `keyword` -> `client`; removed `ie` and `oe` charsets (per @mkaply)
@cvan
Copy link
Contributor

cvan commented Jan 8, 2019

handled in PR #916

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants