The volume slider from immersive mode remains displayed even after moving the pointer away from its active controller area

[heres-maria-sv-inactive]

[Affected Versions]:

• Firefox Reality version 10-40720037 (dbb8ed3)
• Firefox Reality version 8.1 (a0fcc8a)
• Firefox Reality version 8 (ad77618)

[Affected Platforms]:

• HTC Vive Focus Plus - Android 7.1.2
• Oculus Quest - Android 7.1.1
• Pico Neo 2 - Android - 8.1.0

[Prerequisites]:

• The headset is turned on, the browser is installed and open.

[Steps to reproduce]:

1. Go to a 360 video (e.g. https://youtu.be/hNAbQYU0wpg).
2. Play it and enter immersive mode.
3. Hover the volume button.
4. Point the pointer away from the volume slider and observe the behavior.

[Expected results]:

• The volume slider is dismissed.

[Actual results]:

• The volume slider remains displayed.

[Notes]:

• The slider remains displayed across different videos.
• The issue is also reproducible for the other types of videos (180, normal, etc) when in immersive mode.
• Moving the pointer over the actionable area several times sometimes dismisses the slider.
• This issue is reproducible in production.
• Design document used as reference.
• Attached is a recording of this issue.

[daron-walters]

here is a video of the fix. As long as the pointer hovers inside the volume button or the slider the slider will stay visible. Every where else it will hide (note there is a 1 second timer before it hide)

[Softvision-GeluHaiduc]

I have verified this issue with the latest Firefox Reality version 10 RC1 (6db2f60) installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Unfortunately the volume slider still remains displayed even after moving the pointer away if previously it was slided to the max or min points on the slider. Here is a video of the issue.

[bluemarvin]

I think we only want to fix major and blocking issues for v10 at this point so moving this to v11.

[daron-walters]

So from the video Gelu posted the issue is that the when dragging the volume slider to the max and min position sometimes the pointer would be dragged outside of the volume control area and the hover would never fire because the hover is outside of the controls area. Added a hover listener for the whole media control that if hover event is outside of control area we would fire a timer to hide c volume control. here is the video of the test from my local (tested on Oculus Quest)

[Softvision-GeluHaiduc]

I have verified this issue with the latest Firefox Reality version 11-141492311 (a9b58ee) installed on the Oculus Go, Pico Neo2 and Pico G2 4K headsets.
The issue seems to be fixed on the Oculus Go but unfortunately it is still reproducible on the Pico devices. Here is a video of the issue, also I wasn't able to verify it on HTC.

[daron-walters]

still researching and will discuss with team Monday just wanted to include my findings (in case i forget)

so the problem is in the Pico Platform Activity when the user clicks the slider and drags it outside of the area they keyup fires and this error gets hit in the onKeyUp of the VRActivity.

here is log statement
2020-06-07 15:10:07.103 17690-17690/org.mozilla.vrbrowser.dev I/VRActivity: onKeyUp KeyCode = 127 dialogShow = -1

Here is a code snippet where it causes the problem
int var3 = PicovrSDK.GetDialogState();
if (this.SeeThroughSettingExist && var3 >= 0) {
........
}
} else {
Log.e("VRActivity", "onKeyUp Boundary Call SeeThrough Setting failed, is there this app?: " + this.SeeThroughSettingExist + ". Is diaglog showed?: " + (var3 >= 0));
}
this leads to the event getting cancelled because for some reason the Dialog State (var3) is -1

Cancelling event due to no window focus: KeyEvent { action=ACTION_UP, keyCode=KEYCODE_MEDIA_PAUSE, scanCode=0, metaState=0, flags=0x28, repeatCount=0, eventTime=19242479, downTime=19242479, deviceId=-1, source=0x101 }

[keianhzo]

@daron-walters I think we should be able to handle the ACTION_CANCEL case here:

FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/ui/views/VolumeControl.java

Lines 51 to 56 in 3f1172f

	mSeekBar.setOnTouchListener((v, event) -> {
	if (event.getAction() == MotionEvent.ACTION_UP) {
	return true;
	}
	return false;
	});

And hide the view in that case.

[daron-walters]

reply @keianhzo thanks for that Manuel I thouight something similar on my local but I wasnt confident it would be the best solution

[Softvision-GeluHaiduc]

I have verified this issue with the latest Firefox Reality version 11-141672019 (418d959) installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Now, the volume slider from immersive mode doesn't remain displayed after moving the pointer away from its active controller area.