Test #1
Merged
Test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving the pointer away - MozillaReality#2948 1. updated code to use the x location of the volume button as the starting point for hover to show/hide slider. Per design doc the slider should show from the beginning of the volume button to the end of the slider 2. added code to handle hide the slider when the x location is outside of the media controls. On oculus quest the x coord is always negetive when pointer is outside control area
…me slider after 1 second of no hover over volume. Fixes MozillaReality#2948
…me slider after 1 second of no hover over volume. Fixes MozillaReality#2948
…et wide hover code for volume slider and moved it to volume button and slider respectively. Fixes MozillaReality#2948
…et wide hover code for volume slider and moved it to volume button and slider respectively. Fixes MozillaReality#2948
…ving the pointer away - MozillaReality#2948 Fixes MozillaReality#2948 Updated change per Manuel that removed widget wide hover code for volume slider and moved it to volume button and slider respectively. Fixes MozillaReality#2948
…/MozillaReality/FirefoxReality into v10/volume_slider_immersive_mode
…et wide hover code for volume slider and moved it to volume button and slider respectively. Fixes MozillaReality#2948 Fixes MozillaReality#2948 Added Handler that automatically hides volume slider after 1 second of no hover over volume. Fixes MozillaReality#2948
…' into v10/volume_slider_immersive_mode
…f no hover over volume. Fixes MozillaReality#2948
…/MozillaReality/FirefoxReality into v10/volume_slider_immersive_mode � Conflicts: � app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/MediaControlsWidget.java
…etween the volume button and slider was not hiding sliderFixes MozillaReality#2948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test