fix: replace --output option of webpack #245
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
force-pushed
the
webpack-cli-output-flag
branch
from
a85b86f to
7289840
Compare
Rob--W
changed the title
rpl
reviewed
Oct 14, 2020
Currently the build/test fails with the following output: ``` Test webextension-polyfill bundled with webpack =============================================== [webpack-cli] Unknown argument: --output [webpack-cli] Unknown argument: /tmp/webpack-bundle.js ? Which flags do you want to use? … ✔ --entry: The entry point(s) of your application e.g. ./src/main.js ✔ --config: Provide path to a webpack configuration file e.g. ./webpack.config.js ✔ --color: Enable/Disable colors on console ✔ --merge: Merge two or more configurations using webpack-merge e.g. -c ./webpack.config.js -c ./webpack.test.config.js --merge ✔ --progress: Print compilation progress during build ✔ --help: Outputs list of supported flags ✔ --output-path: Output location of the file generated by webpack e.g. ./dist/ ``` Regressed by: webpack/webpack-cli#1855 webpack/webpack-cli@2f36b9d `--output` has been renamed to `--output-path` (`-o` in both cases), but stopped supporting file names. To output to a specific absolute path, `--output-path` and `--output-filename` must both be specified, with the directory in the former and the filename in the latter.
Rob--W
force-pushed
the
webpack-cli-output-flag
branch
from
7289840 to
bd09318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build/test fails with the following output:
Regressed by:
webpack/webpack-cli#1855
webpack/webpack-cli@2f36b9d
--outputhas been renamed to--output-path(-oin both cases), but stopped supporting file names.To output to a specific absolute path,
--output-pathand--output-filenamemust both be specified, with the directory in the former and the filename in the latter.