Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn web-ext v7 users about upcoming changes to the sign command #2879

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

willdurand
Copy link
Member

Fixes #2877


This will look like this:

❯ ./bin/web-ext.js sign --api-key="foo" --api-secret="bar"
Applying config file: ./package.json
IMPORTANT: web-ext v8 will introduce a new AMO submission API for signing and you might need to take actions when upgrading from v7 to v8. You can test this upcoming change now by specifying `--use-submission-api` to the `sign` command. If you want to keep using the API you are using now (via "sign-addon"), you must stay on v7.

[...]

@willdurand willdurand requested a review from rpl September 14, 2023 08:00
@willdurand willdurand changed the title Warn web-ext v7 users about upcoming changes to the sign command feat: warn web-ext v7 users about upcoming changes to the sign command Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3bc0548) 99.53% compared to head (57acda7) 99.53%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           minor-releases-7.x.x    #2879   +/-   ##
=====================================================
  Coverage                 99.53%   99.53%           
=====================================================
  Files                        32       32           
  Lines                      1705     1707    +2     
=====================================================
+ Hits                       1697     1699    +2     
  Misses                        8        8           
Files Changed Coverage Δ
src/cmd/sign.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand merged commit 6f07d1e into minor-releases-7.x.x Sep 14, 2023
@willdurand willdurand deleted the warn-v7 branch September 14, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants