Fix support for typedoc 0.19 #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add a github workflow matrix that tests against different versions of typedoc and a fixed version of Python. |
|
I think the correct definition for def _containing_deppath(self, node) -> str:
return node["sources"][0]['fileName']The hack I have in the current PR stops working in v0.20 because it seems like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
typedoc v0.15 and 0.16 work
After this PR:
v0.15 and 0.16 still work
v0.17 and 0.18 mess up the type name for tuple types due to a bug in these versions of typedoc
TypeNameTests::test_basic - AssertionError: assert '<TODO: other type>' == '[string, number]'
v0.19 works
v0.20+: crash (cannot render anything because "sources" key not always present on nodes and there is another deppath problem).
@rth @ryanking13