Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

feat(main-route): develop Start screen UI to match UI mockups #20

Merged
merged 2 commits into from
Sep 17, 2014
Merged

feat(main-route): develop Start screen UI to match UI mockups #20

merged 2 commits into from
Sep 17, 2014

Conversation

Glavin001
Copy link
Contributor

With @Frozenfire92 @rainbee2214

Mockup

mockup

Screenshot

image

@Glavin001 Glavin001 changed the title Develop Start screen UI to match UI mockups. feat(main-route): develop Start screen UI to match UI mockups Sep 17, 2014
@Glavin001
Copy link
Contributor Author

@Kallada , feel free to merge when you're ready 👍. @Frozenfire92 and @rainbee2214 and I have already reviewed this PR.

@MatKallada
Copy link
Contributor

Remove the "Made with <3" part

@Glavin001
Copy link
Contributor Author

Should we change it to a copyright or something else?

@MatKallada
Copy link
Contributor

No; to be honest, the footer is unnecessary. Keep it clean and remove it entirely for now.

Eventually, we might come back to put something there, but for now remove it.

@Glavin001
Copy link
Contributor Author

I've already started working on another branch that extends this. I will

  • remove footer
    in the other branch.

Consider this Pull Request complete and ready to be merged. I will make another PR later with that change.

@MatKallada
Copy link
Contributor

Great, 👍

Side note: Why not push to this PR itself?

Glavin001 added a commit that referenced this pull request Sep 17, 2014
@Glavin001
Merge pull request #20 from mozilla/start-screen-ui
209e701 
feat(main-route): develop Start screen UI to match UI mockups
@Glavin001 Glavin001 merged commit 209e701 into master Sep 17, 2014
@MatKallada MatKallada deleted the start-screen-ui branch September 17, 2014 21:12
@MatKallada MatKallada restored the start-screen-ui branch September 17, 2014 21:12
@Glavin001
Copy link
Contributor Author

Side note: Why not push to this PR itself?

I just wanted to split up the logical pieces and also get this merged into master sooner while I work on the much bigger draw route ( #24 ).

@MatKallada MatKallada deleted the start-screen-ui branch June 27, 2015 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Glavin001 @MatKallada