Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Scaffold the foundation for this project #1

Closed
10 tasks done
Glavin001 opened this issue Aug 10, 2014 · 10 comments
Closed
10 tasks done

Scaffold the foundation for this project #1

Glavin001 opened this issue Aug 10, 2014 · 10 comments
Assignees

Comments

@Glavin001
Copy link
Contributor

Dependencies:

TODO:

@Glavin001 Glavin001 self-assigned this Aug 10, 2014
@MatKallada MatKallada assigned MatKallada and unassigned Glavin001 Aug 10, 2014
Glavin001 added a commit that referenced this issue Aug 10, 2014
Used generator-angular with --coffee flag enabled.

See #1.
@MatKallada
Copy link
Contributor

Thanks for using the generator, but I don't entirely think we should start scaffolding until we have fully agreed on our final plan and outline, since it is still a bit shaky now.

@Glavin001
Copy link
Contributor Author

Well we know the technologies we intend on using (Angular, CoffeeScript, and JsPlumb), so that is unlikely to change (I believe @curtisko said it is up to us and we have discussed this at length already); and I put this in an issue branch for that very reason, if we end up going down this route, we can simply merge the Pull Request or reject it if not.

@Glavin001 Glavin001 reopened this Aug 10, 2014
@Glavin001 Glavin001 assigned Glavin001 and unassigned MatKallada Aug 10, 2014
@Glavin001
Copy link
Contributor Author

You do bring up a good point: up until now our discussion has been primarily via Facebook messages. I would like to get on record (in GitHub issues, possibly here?) the discussion (pros and cons) for our project foundation. If you have concerns about the foundation we have previously discussed, please start the discussion here :).

Once I am finished the scaffolding I will be submitting a Pull Request, which the team and collectively discuss and merge or reject. If we change direction again and it is rejected, then no harm done because I have still learned a little Angular and that is what it is all about: learning 👍.

@MatKallada
Copy link
Contributor

Thanks for the update. Actually, I have already put everything on the Wiki and am guessing everything involving technical design to go there. I don't have really have any concerns, but there seems to be new things introduced here. Do you mind first noting your plans (maybe on the discussion section of the Wiki), so that the team can follow and stay on the same track 🎯 ?

Thanks ✌️

@Glavin001
Copy link
Contributor Author

I don't have really have any concerns, but there seems to be new things introduced here.

I do not see anything new. What jumps out at you?

Do you mind first noting your plans (maybe on the Wiki), so that the team can follow and stay on the same track 🎯 ?

Absolutely! :)

Actually, I have already put everything on the Wiki and am guessing everything involving technical design to go there

I do not see anything in the project's wiki: https://github.com/mozilla/seasponge/wiki
image

I am guessing you mean the wiki here: https://wiki.mozilla.org/Security/Mentorships/MWoS/2014/online_threat_modeling_tool

How do I edit that? I am not setup there yet. A little help would be appreciated :).

The current Technical Design section of the wiki looks right to me.

To keep things simple - our application is completely client-side. Users may export their projects and save them onto their hard drives (and load them later on), or they may save their projects onto local storage.

Software Description
Twitter Bootstrap A front-end framework used for clean design
jsPlumb A powerful HTML5 graph drawing toolkit
AngularJS Client-side MVC Framework for single-page web applications

We are using Twitter Bootstrap, AngularJS, and jsPlumb, with CoffeeScript instead of JavaScript (as discussed via Facebook message).

I can add the CoffeeScript part in once I have access to the wiki. Will get on that now.

@Glavin001
Copy link
Contributor Author

I was originally thinking we should Unit Test the inclusion of Bower dependencies, because @Frozenfire92 and I have had troubles in the past with dependencies not being included and the errors that it caused were cryptic and not obvious that a missing dependency was the cause.

However, it appears that the Grunt task for building the web app will actually notify the developer now when a dependency is not properly injected:
image

So that solves that!

Update: Actually this is an issue with the Bower version of jsPlumb, not having a main in it's bower.json file. See http://stackoverflow.com/a/23436755 for workaround.

@MatKallada
Copy link
Contributor

I just added CoffeeScript to dependencies on the MozWiki. Also, you can request a Wiki account by clicking on the sidebar.

Side note: It might be a good idea to make use of the GitHub wiki as well - perhaps for infrastructure things. Any thoughts Glav?

-Mat

@Glavin001
Copy link
Contributor Author

I would prefer the GitHub wiki. It is version controlled with Git, publically access, immediately modifiable by contributors, and I like the rendered wiki UI better (the Mozilla wiki does not provide links for header ideas, whereas GitHub markdown creates anchor links for headers, which are valuable for referencing).

The Mozilla wiki can be as it is now, and link to the GitHub wiki for more details 👍.

@Glavin001
Copy link
Contributor Author

I just added CoffeeScript to dependencies on the MozWiki.

Thanks!

Also, you can request a Wiki account by clicking on the sidebar.

I requested a Wiki account here: https://wiki.mozilla.org/Special:RequestAccount

Although that'll take time and I'm not very interested in waiting right now :P. There is work to be done! Let's continue with the GitHub wiki from here on out.

Update: Wow, I just received confirmation of approval for MozillaWiki. That was fast! 😃

@Glavin001
Copy link
Contributor Author

Looks like Travis CI was already setup with the generator. However, maybe I should say almost setup. There is a bug: Travis CI logs show:

Warning: Running "compass:dist" (compass) task
Warning: You need to have Ruby and Compass installed and in your system PATH for this task to > work. More info: https://github.com/gruntjs/grunt-contrib-compass� Use --force to continue.

I've encountered this many times before. Solution can be found here among many other places.

Glavin001 referenced this issue Aug 10, 2014
Add `description`, `directories`, `repository`, `keywords`, `license`,
`bugs`, and `homepage`  fields to package.json

Add AUTHORS file, instead of providing `contributors` field in
package.json
Glavin001 referenced this issue Aug 10, 2014
Glavin001 referenced this issue Aug 10, 2014
The Bower version of jsPlumb does not include a `main`
field in it's bower.json file.
The solution was to set an `overrides` field in
this project's bower.json field to patch jsPlumb's.

See
http://stackoverflow.com/questions/21357719/configure-grunt-bower-install-path-for-a-component/23436755#23436755
MatKallada pushed a commit that referenced this issue Aug 10, 2014
refactor(app): Closes #1. Setup foundation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants