Pass through --remap-path-prefix argument.
#2270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
+ Coverage 30.91% 40.71% +9.80%
==========================================
Files 53 54 +1
Lines 20112 20747 +635
Branches 9755 9642 -113
==========================================
+ Hits 6217 8448 +2231
- Misses 7922 8152 +230
+ Partials 5973 4147 -1826 ☔ View full report in Codecov by Sentry. |
|
Bump Is there anybody else who could review my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see what's special about the
--remap-path-prefixargument that it was marked asTooHardand not just passed through.I'm changing it to
PassThroughhere. This change has worked in a local test.Please put my PR under scrutiny. This argument has been unsupported by sccache for a long time and it feels too simple to just change it to
PassThrough.