-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify server timeout #2246
base: main
Are you sure you want to change the base?
Specify server timeout #2246
Conversation
08dd678
to
4788cba
Compare
If a breaking change will occur in 0.9, like @Xuanwo had mentioned in PR #2235, talking about the issue to replace |
7f21e71
to
554425c
Compare
seems that rustfmt needs to be run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
===========================================
+ Coverage 30.91% 51.67% +20.76%
===========================================
Files 53 54 +1
Lines 20112 20751 +639
Branches 9755 9795 +40
===========================================
+ Hits 6217 10724 +4507
- Misses 7922 8026 +104
+ Partials 5973 2001 -3972 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that rustfmt needs to be run
also, could you please document this into the readme file? thanks
…ngineer/sccache into specify-server-timeout, resolve conflicts
@sylvestre, could I make a flag doc or something along those lines? I feel like the readme is getting too long. Perhaps |
This should fix issue #2237, where in the case a compilation is still ongoing when a shutdown request is sent, and it's a larger/complex codebase that takes longer than the default 10 seconds, the user can now specify it in their config file.
However, I'd like to also propose a breaking change for config files, moving server_startup_timeout_ms and server_shutdown_timeout_ms to a specific timing struct. I left the code in there to do this, just commented out. I'd like to make this change next time we bump up a major version.
Although I can remove the comments to clean up the code until then. But what's the best practice for marking a milestone? Should I raise an issue?