Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle # env-dep directives in dep-info files #804

Closed
luser opened this issue Jun 26, 2020 · 0 comments · Fixed by #1107
Closed

Handle # env-dep directives in dep-info files #804

luser opened this issue Jun 26, 2020 · 0 comments · Fixed by #1107

Comments

@luser
Copy link
Contributor

luser commented Jun 26, 2020

rustc nightly added support for adding extra annotations in the form of Makefile comments to dep-info files to track environment variables accessed by way of the env! macro. sccache should parse these directives and add referenced environment variables as hash inputs.

@alexcrichton has a pull request open to add support to cargo. I'm sure it'd be straightforward to add support to sccache's parser.

bmwill added a commit to bmwill/diem that referenced this issue Jan 14, 2021
We're currently seeing an issue with some tests that use the trybuild
crate to run. When trybuild is compiled it looks at the `CARGO` env var
in order to determine which `cargo` binary to use during tests.
Unfortunately sccache isn't able to properly cache artifacts which
depend on environment variables at compile time, resulting in the cached
version of trybuild trying to use a nonexistent version of cargo. This
should be fixed once mozilla/sccache#804 is
fixed.
bors-libra pushed a commit to diem/diem that referenced this issue Jan 14, 2021
We're currently seeing an issue with some tests that use the trybuild
crate to run. When trybuild is compiled it looks at the `CARGO` env var
in order to determine which `cargo` binary to use during tests.
Unfortunately sccache isn't able to properly cache artifacts which
depend on environment variables at compile time, resulting in the cached
version of trybuild trying to use a nonexistent version of cargo. This
should be fixed once mozilla/sccache#804 is
fixed.

Closes: #7241
bors-libra pushed a commit to diem/diem that referenced this issue Jan 15, 2021
We're currently seeing an issue with some tests that use the trybuild
crate to run. When trybuild is compiled it looks at the `CARGO` env var
in order to determine which `cargo` binary to use during tests.
Unfortunately sccache isn't able to properly cache artifacts which
depend on environment variables at compile time, resulting in the cached
version of trybuild trying to use a nonexistent version of cargo. This
should be fixed once mozilla/sccache#804 is
fixed.

Closes: #7241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant