Pad to multiples of 128 bytes, rather than to a random length. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the padding techniques suggested in the RFC, and while we can't choose a default scheme that will work well for all applications, this one at least seems easier to reason about. Fixes #54.
jrconlin
approved these changes
Mar 24, 2021
| @@ -14,7 +14,7 @@ const ECE_AES128GCM_HEADER_LENGTH: usize = 21; | |||
| // The max AES128GCM Key ID Length is 255 octets. We use far less of that because we use | |||
| // the "key_id" to store the exchanged public key since we don't cache the key_ids. | |||
| // Code fails if the key_id is not a public key length field. | |||
| const ECE_AES128GCM_PAD_SIZE: usize = 1; | |||
| pub(crate) const ECE_AES128GCM_PAD_SIZE: usize = 1; | |||
There was a problem hiding this comment.
part of me REALLY wants this to be just ECE_PAD_SIZE and kinda force the point by requiring the package if you want to use both (e.g. aes128gcm.ECE_PAD_SIZE), but that might lead to unintended bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the padding techniques suggested in the RFC, and while
we can't choose a default scheme that will work well for all applications,
this one at least seems easier to reason about.
Fixes #54.