Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from new-ordered-float to ordered-float #79

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

mbrubeck
Copy link
Contributor

The new-ordered-float fork has been merged back into the original ordered-float crate.

The `new-ordered-float` fork has been merged back into the original
`ordered-float` crate.
@mykmelez mykmelez merged commit 739975d into mozilla:master Sep 11, 2018
@mykmelez
Copy link
Contributor

@mbrubeck Thanks for the fix! Is there an equivalent for the servo/components/style/ directory in mozilla-central? I'd like to keep rkv dependencies aligned with those of Gecko as much as possible, to avoid redundancy when vendoring rkv into mozilla-central.

@mbrubeck
Copy link
Contributor Author

See servo/servo#21681. @emilio has been merging changes from the servo repo to mozilla-central periodically. (This is very tiny dependency so it's probably fine if it gets temporarily out of sync, though.)

@emilio
Copy link
Contributor

emilio commented Sep 12, 2018

Yeah, I sync back roughly every week, more or less.

@mykmelez
Copy link
Contributor

@mbrubeck @emilio That sounds great. I don't sync rkv as often, but I can do so around the same time as the next sync of Servo, to minimize the time that the two are out of sync wrt. this dependency. Just let me know when you plan to do it, and I'll publish a new version of rkv and sync Gecko.

@emilio
Copy link
Contributor

emilio commented Sep 15, 2018

I just did the sync in https://bugzilla.mozilla.org/show_bug.cgi?id=1491577.

@mykmelez
Copy link
Contributor

I published the new version of rkv on September 19, but it took longer than expected to update Gecko to that version, as I've been waiting for @Eijebong to update uuid in Gecko, as we discussed in #77.

I had some time today to do both, however, so I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1500259 on updating rkv and submitted https://phabricator.services.mozilla.com/D9160 to update rkv to 0.5 and uuid to 0.6.

(Just in time for uuid 0.7 to be released a few days ago. 😉 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants