Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, I got this error when I ran the test.
rhino/src/org/mozilla/classfile/ClassFileWriter.java
Lines 2176 to 2181 in 1f45c8f
UNINITIALIZED_THIS
example:
It is correct to rewrite the
UNINITIALIZED_THIS
type withthis.getClass()
in this case.UNINITIALIZED_VARIABLE(0)
example:
It is probably correct to rewrite it with
BigInteger
instead ofthis.getClass()
in this case.I'm not familiar with Java bytecode, so could you please check if the pull request is correct?