Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of unicode characters in the lexer #1464

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

andreabergia
Copy link
Contributor

@rbri
Copy link
Collaborator

rbri commented Apr 18, 2024

@andreabergia looks promising, can you please have a look at the failing tests...

Unfortunately, some of the tests pass only on higher version of the JDK,
because they have updated unicode support. On JDK 1.8 we get a lot of
failures that we aren't getting on Java 11 or 17.
@andreabergia
Copy link
Contributor Author

The problem is that the behavior of the Java unicode checks differs depending on the JDK - so the same code might say that a character is a valid unicode identifier on java 11 but not on java 8. Some tests of test262 are failing because of that, it seems.
I had originally run locally the test262 updater with JDK11. I've rerun it with JDK 1.8 and it looks like CI passes now. 🙂

@rbri
Copy link
Collaborator

rbri commented Apr 27, 2024

Thanks a lot @andreabergia, another step forward.

@rbri rbri merged commit 88eb66a into mozilla:master Apr 27, 2024
3 checks passed
@andreabergia andreabergia deleted the fix-unicode-identifier branch April 30, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants