[Bug 1473091] Migrate mozilla/redash to circleci 2.0 #488
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # These environment variables must be set in CircleCI UI | ||
| # | ||
| # DOCKERHUB_REPO - docker hub repo, format: <username>/<repo> | ||
| # DOCKER_USER | ||
| # DOCKER_PASS | ||
| # | ||
|
|
||
| version: 2 | ||
| jobs: | ||
| build: | ||
| docker: | ||
| - image: docker:18.02.0-ce | ||
| working_directory: ~/mozilla/redash | ||
| steps: | ||
| - checkout | ||
| - setup_remote_docker | ||
| - run: | | ||
| printf '{"commit":"%s","version":"%s","source":"https://github.com/%s/%s","build":"%s"}\n' "$CIRCLE_SHA1" "$CIRCLE_TAG" "$CIRCLE_PROJECT_USERNAME" "$CIRCLE_PROJECT_REPONAME" "$CIRCLE_BUILD_URL" > version.json | ||
| - run: | ||
| command: docker build -t app:build . | ||
| no_output_timeout: 20m | ||
|
|
||
| test: | ||
| docker: | ||
| - image: circleci/node:6.14.3-stretch | ||
| - image: redis | ||
| - image: circleci/postgres:10-alpine-postgis | ||
| working_directory: ~/mozilla/redash | ||
| steps: | ||
| - checkout | ||
| - run: mkdir -p /tmp/test-reports/pytest | ||
| - run: sudo apt-get update | ||
| - run: sudo apt-get install -y python-pip python-dev | ||
| - run: sudo apt-get install -y redis-tools redis-server | ||
| - run: sudo pip install --upgrade setuptools | ||
| - run: sudo pip install -r requirements_dev.txt | ||
| - run: sudo pip install -r requirements.txt | ||
| - run: sudo npm install | ||
| - run: sudo npm run build | ||
| - run: | ||
| command: pytest --junitxml=/tmp/test-reports/pytest/junit.xml tests/ | ||
| environment: | ||
| REDASH_REDIS_URL: redis://localhost:6379/0 | ||
| REDASH_DATABASE_URL: "postgresql://postgres@localhost/postgres" | ||
| - store_artifacts: | ||
| path: /tmp/test-reports/ | ||
| destination: tr1 | ||
| - store_test_results: | ||
| path: /tmp/test-reports/ | ||
|
|
||
| deploy: | ||
| docker: | ||
| - image: docker:18.02.0-ce | ||
| working_directory: ~/mozilla/redash | ||
| steps: | ||
| - checkout | ||
| - setup_remote_docker | ||
| - run: | ||
| name: Deploy to Dockerhub | ||
| no_output_timeout: 20m | ||
| command: | | ||
| # Deploy master | ||
| if [ "${CIRCLE_BRANCH}" == "master" ]; then | ||
| ./bin/deploy "master" | ||
| else | ||
| # Deploy a release tag... | ||
| ./bin/deploy "rc" | ||
| fi | ||
|
There was a problem hiding this comment. Could we split the deploy job into two jobs deploy-master and deploy-rc (and update the workflows below) instead of having the shell script with the condition? That would make it more obvious in the Circle UI what's happening. |
||
|
|
||
| deploy-milestone: | ||
| docker: | ||
| - image: docker:18.02.0-ce | ||
| working_directory: ~/mozilla/redash | ||
| steps: | ||
| - checkout | ||
| - setup_remote_docker | ||
| - run: | ||
| name: Deploy milestone to Dockerhub | ||
| no_output_timeout: 20m | ||
| command: | | ||
| ./bin/deploy "$CIRCLE_TAG" | ||
| ./bin/alias "$CIRCLE_TAG" "latest" | ||
|
|
||
|
|
||
| workflows: | ||
| version: 2 | ||
| build-test-deploy: | ||
| jobs: | ||
| - build: | ||
| filters: | ||
| tags: | ||
| only: /.*/ | ||
| branches: | ||
| ignore: | ||
| - gh-pages | ||
|
|
||
| - test: | ||
| filters: | ||
| tags: | ||
| only: /.*/ | ||
| branches: | ||
| ignore: | ||
| - gh-pages | ||
|
|
||
| - deploy: | ||
| requires: | ||
| - test | ||
| filters: | ||
| tags: | ||
| only: /.*/ | ||
| branches: | ||
| only: | ||
| - master | ||
| - release | ||
|
|
||
| - deploy-milestone: | ||
| requires: | ||
| - test | ||
| filters: | ||
| tags: | ||
| only: /^m[0-9]+(\.[0-9]+)?$/ | ||
| branches: | ||
| ignore: /.*/ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand the purpose of the build job and can't find an equivalent in the old config. It's run for every tag and all branches except gh-pages IIUC. Is this just to make sure the image build succeeds?
Could we remove the writing of the
version.jsonsince it was abstracted away in thebin/deployscript for the other jobs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's just to ensure that the image builds properly. I will remove the version.json for the build step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks!