-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard overwrite on conflict for query owners (re #283) #327
Conversation
2618326
to
bf7370c
Compare
1248809
to
1db911f
Compare
@washort So with the looming issue of staying close with upstream in terms of API usage I just looked again at the toastr calls there. There are no uses of HTML in toastr popups and I think that means we should stay away from that as well. In stead I think we can safely use the window.confirm function instead as it's used in various places in the code. And since our confirmation query only applies to query owners it's okay UX wise. In other words, depending on |
@washort Do you want me to take a stab at this? (I know you've spent lots of time on this already) |
Sure, if you don't mind having a look. |
1db911f
to
c2cf29e
Compare
c2cf29e
to
6508675
Compare
@washort Okay, found an own AlertDialog thing actually, which is what is used in other places already that fits the bill better than |
6508675
to
5079ca2
Compare
r+, this is obviously a better solution |
This got merged upstream as well. |
This fixes #283 though I'd love to see a better way to handle an action in a toastr notification than setting a global function as callback.