Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary section separators displayed in the option menu for an archived query #319

Closed
madalincm opened this issue Jan 26, 2018 · 2 comments · Fixed by #414
Closed

Unnecessary section separators displayed in the option menu for an archived query #319

madalincm opened this issue Jan 26, 2018 · 2 comments · Fixed by #414
Assignees
@alison985
Labels
bug in review UI Changes verified fixed
Milestone
14

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open the page for an archived query: https://pipeline-sql.stage.mozaws.net/queries/258/source
  2. Click on the options button

Expected results:

There are no layout issues

Actual results:

There are are 2 section separators displayed in the drop down menu

Notes/Issues:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in FF58(Win7). Issue can be reproduced in STMO-stage
uichangesoptionbuttonarchivedquery
@rafrombrc rafrombrc added this to the 14 milestone Feb 21, 2018
@madalincm
Copy link
Author

Verified in FF58(Win7x64) in stmo-stage
Issue is still reproducing:
319reopen

@alison985 alison985 self-assigned this Jun 3, 2018
@alison985 alison985 mentioned this issue Jun 3, 2018
Closed
alison985 added a commit to alison985/mozilla-redash that referenced this issue Jun 6, 2018
@alison985
removes menu divider line if archived
e78990d 
fixes mozilla#319
This was referenced Jun 6, 2018
Merged
Closed
alison985 added a commit to StantonVentures/redash that referenced this issue Jun 6, 2018
@alison985
remove extra menu line if query is archived
2982d77 
fixes getredash#2571

Sames as mozilla#319 fixed in mozilla#414
@alison985 alison985 mentioned this issue Jun 6, 2018
Merged
alison985 added a commit that referenced this issue Jun 6, 2018
@alison985
319 remove menu line (#414)
b3bf51c 
* fix the annoying space error

* removes menu divider line if archived

fixes #319
@madalincm
Copy link
Author

Verifed as fixed in FF60 (Win7)
Postfix screencast:
removedseparator

Marking bug as verified fixed.

@snyk-bot snyk-bot mentioned this issue Aug 18, 2021
Open
@MaxMood96 MaxMood96 mentioned this issue Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 26, 2022
Open
@MaxMood96 MaxMood96 mentioned this issue Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alison985 alison985

Labels
bug in review UI Changes verified fixed
Projects
None yet
Milestone
14
3 participants
@rafrombrc @alison985 @madalincm