Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error messages w sql syntax errors #290

Closed
rafrombrc opened this issue Dec 14, 2017 · 3 comments
Closed

Misleading error messages w sql syntax errors #290

rafrombrc opened this issue Dec 14, 2017 · 3 comments
Milestone

Comments

@rafrombrc
Copy link
Member

rafrombrc commented Dec 14, 2017

SQL syntax errors are generating scary error messages that look like bigger redash failures in sentry, we need to make sure users are seeing accurate errors and hopefully that they're not showing up in sentry at all.

@rafrombrc rafrombrc added this to the 13 milestone Dec 14, 2017
@rafrombrc rafrombrc changed the title Improved error messages Misleading error messages w sql syntax errors Feb 21, 2018
@washort
Copy link

washort commented Feb 21, 2018

Example - https://sentry.prod.mozaws.net/operations/data-stmo-prod/issues/1816645/

Celery uses JSON for messaging instead of pickle now and thus fails here. It's still showing the error to the user.

@washort
Copy link

washort commented Feb 27, 2018

Fixed. The task code was returning an exception object rather than raising it.

@madalincm
Copy link

I have simulated some sql sytax errors and at this moment in stage the error messages look a bit generic:
290
Any kind of syntax error is generating a message that looks like that which might be not that helpful.

In production we would something much clearer about what the issue really is:
Error running query: QueryExecutionError(u"line 1:173: mismatched input 'rfom' expecting {, ',', 'EXCEPT', 'FROM', 'GROUP', 'HAVING', 'INTERSECT', 'LIMIT', 'ORDER', 'UNION', 'WHERE'}",) is not JSON serializable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants