Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Protocol ES5 to modern JS #255

Closed
alexgibson opened this issue Oct 26, 2018 · 3 comments
Closed

Convert Protocol ES5 to modern JS #255

alexgibson opened this issue Oct 26, 2018 · 3 comments
Assignees
Labels
Dev ready ⚙️ Indicates the story/card/tasks are ready to be coded Refactor 👩‍🏭

Comments

@alexgibson
Copy link
Member

alexgibson commented Oct 26, 2018

Since this issue was originally opened Bedrock has migrated much of its JS from ES5 to modern JS syntax, and now supports things like ES modules. We use webpack to transpile to ES5 for backward compatibility.

I'd like to do the same here for Protocol's JS components, so that we can enjoy more parity between writing for Protocol and writing for Bedrock.

Doing this will make it easier for other websites to consume Protocol in a modern build system. It will also unlock backporting things from Bedrock to Protocol, such as the Basket newsletter logic.

The Protocol JS components should be output in UMD format, to support the widest possible range of import / usage methods.

We'll need to test to make sure things import into Bedrock OK as we go.

@alexgibson alexgibson added the Wishlist ✨ Feature requests. label Oct 26, 2018
@stephaniehobson
Copy link
Contributor

Why not ES6 compiling to ES5?

@alexgibson
Copy link
Member Author

Why not ES6 compiling to ES5?

ES6 was renamed ES2015, so they are the same thing :)

@stephaniehobson stephaniehobson added the Dev ready ⚙️ Indicates the story/card/tasks are ready to be coded label Apr 11, 2019
@johngruen johngruen added Refactor 👩‍🏭 and removed Wishlist ✨ Feature requests. labels Aug 2, 2019
@johngruen johngruen added this to the 🦗 Hopper milestone Aug 2, 2019
@alexgibson
Copy link
Member Author

alexgibson commented Nov 28, 2022

I'm gonna work on this as it will unblock other things such as: #839

@alexgibson alexgibson self-assigned this Nov 28, 2022
@alexgibson alexgibson removed this from the 🦗 Hopper milestone Nov 28, 2022
@alexgibson alexgibson changed the title Convert Protocol JS to ES2015 Convert Protocol JS to modern JS Mar 2, 2023
@alexgibson alexgibson changed the title Convert Protocol JS to modern JS Convert Protocol ES5 to modern JS Mar 2, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Mar 22, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 4, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 12, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 12, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 17, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 17, 2023
alexgibson added a commit to alexgibson/protocol that referenced this issue Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev ready ⚙️ Indicates the story/card/tasks are ready to be coded Refactor 👩‍🏭
Projects
None yet
Development

No branches or pull requests

3 participants