Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the Scroll/Spread mode buttons if the viewer is a PDFSinglePageViewer instance (PR 9858 follow-up) #9877

Merged
merged 3 commits into from
Jul 8, 2018
Merged

Hide the Scroll/Spread mode buttons if the viewer is a PDFSinglePageViewer instance (PR 9858 follow-up) #9877

merged 3 commits into from
Jul 8, 2018

Commits on Jul 8, 2018

  1. Simplify resetting of the SecondaryToolbar Scroll/Spread mode butto… 

    …ns, and add a missing comment in `PDFCursorTools`

The names 'resetscrollmode'/'resetspreadmode' were probably *not* great choices, given that the only thing being reset are toolbar buttons and not the actual Scroll/Spread modes. Furthermore, there's really no need for two separate events here.

The patch also adds a comment that ought to have been included in PR 9040, to prevent future refactoring/removing of what may appear to be an unnecessary `Promise.resolve` call.
    @Snuffleupagus
    Snuffleupagus committed Jul 8, 2018
    Configuration menu
    Copy the full SHA
    46e1d5d View commit details
    Browse the repository at this point in the history

  2. Hide the Scroll/Spread mode buttons when the viewer is a `PDFSinglePa… 

    …geViewer` instance

If the current viewer is a `PDFSinglePageViewer` instance the Scroll/Spread modes are no-ops, hence displaying buttons that do *nothing* when clicked will probably do very little besides confuse users.
    @Snuffleupagus
    Snuffleupagus committed Jul 8, 2018
    Configuration menu
    Copy the full SHA
    36d6255 View commit details
    Browse the repository at this point in the history

  3. Temporarily disable the Spread mode buttons when horizontal scrolling… 

    … is enabled

Given that the non-default Spread modes (currently) doesn't affect the page layout when horizontal scrolling is enabled, having the Spread buttons appear active when clicking them appears to do *nothing* is probably confusing rather than helpful to users.
    @Snuffleupagus
    Snuffleupagus committed Jul 8, 2018
    Configuration menu
    Copy the full SHA
    d8c2bcc View commit details
    Browse the repository at this point in the history