Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PDFFindController to use the 'pagesinit' event, dispatched on the eventBus, to resolve the _firstPagePromise #9861

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Refactor PDFFindController to use the 'pagesinit' event, dispatched on the eventBus, to resolve the _firstPagePromise #9861

merged 1 commit into from
Jul 2, 2018

Commits on Jul 1, 2018

  1. Refactor PDFFindController to use the 'pagesinit' event, dispatched… 

    … on the `eventBus`, to resolve the `_firstPagePromise`

Rather than having to manually call a method on `PDFFindController` instances from `BaseViewer.setDocument`, thus essentially having to resolve the private `_firstPagePromise` from the "outside", this can be done easily with the 'pagesinit' event dispatched on the `eventBus` instead.
Please note this particular `PDFFindController` code pre-dates the `eventBus` by almost three years, which should explain why the code looks the way it does.
    @Snuffleupagus
    Snuffleupagus committed Jul 1, 2018
    Configuration menu
    Copy the full SHA
    39a1fce View commit details
    Browse the repository at this point in the history